Skip to content

Commit 10bf615

Browse files
guss77AlexWaygood
andauthored
gh-108172: do not override OS preferred browser if it is a super-string of a known browser (GH-113011)
When checking if the registering browser is the "OS preferred browser", do not use a substring search - that makes no sense: one can have a preferred browser that looks like a super-string of a known browser, e.g. "firefox-nightly" vs "firefox". #108172 explains in more detail, and lays out a potential better future enhancement for this case of just using xdg-open. We'll go with this for now. --------- Co-authored-by: Alex Waygood <[email protected]>
1 parent 74bfb53 commit 10bf615

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Lib/webbrowser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def register(name, klass, instance=None, *, preferred=False):
3131
# Preferred browsers go to the front of the list.
3232
# Need to match to the default browser returned by xdg-settings, which
3333
# may be of the form e.g. "firefox.desktop".
34-
if preferred or (_os_preferred_browser and name in _os_preferred_browser):
34+
if preferred or (_os_preferred_browser and f'{name}.desktop' == _os_preferred_browser):
3535
_tryorder.insert(0, name)
3636
else:
3737
_tryorder.append(name)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
``webbrowser`` honors OS preferred browser on Linux when its desktop entry name contains the text of a known browser name.

0 commit comments

Comments
 (0)