Skip to content

Commit 178568b

Browse files
committed
Test coverage increased
1 parent cfac9a1 commit 178568b

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

Lib/test/test_threading.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,19 +1082,28 @@ def test_init_immutable_default_args(self):
10821082
timer2 = threading.Timer(0.01, self._callback_spy)
10831083
timer2.start()
10841084
self.callback_event.wait()
1085+
self.assertEqual(len(self.callback_args), 2)
1086+
self.assertEqual(self.callback_args, [((), {}), ((), {})])
1087+
1088+
def _callback_spy(self, *args, **kwargs):
1089+
self.callback_args.append((args[:], kwargs.copy()))
1090+
self.callback_event.set()
10851091

10861092
def test_continuous_execution(self):
1087-
timer = threading.Timer(0.01, self._callback_cont)
1093+
timer1 = threading.Timer(0.01, self._callback_cont)
10881094
self.callback_event.clear()
1089-
timer.start()
1095+
timer1.start()
10901096
for i in range(3):
1091-
self.callback_event.wait(1)
1097+
self.callback_event.wait(1.0)
10921098
self.callback_event.clear()
10931099
self.assertEqual(self.callback_cnt, 0)
1094-
1095-
def _callback_spy(self, *args, **kwargs):
1096-
self.callback_args.append((args[:], kwargs.copy()))
1097-
self.callback_event.set()
1100+
self.callback_cnt = 3
1101+
timer2 = threading.Timer(0.5, self._callback_cont)
1102+
self.callback_event.clear()
1103+
timer2.start()
1104+
timer2.cancel()
1105+
timer2.join(2.0)
1106+
self.assertEqual(self.callback_cnt, 3)
10981107

10991108
def _callback_cont(self):
11001109
self.callback_cnt -= 1

Lib/threading.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1177,7 +1177,7 @@ def cancel(self):
11771177
self.finished.set()
11781178

11791179
def run(self):
1180-
"""Continue execution after wait until function returns True"""
1180+
"""Continue execution after wait till function returns True"""
11811181
while(not self.finished.wait(self.interval)):
11821182
if not self.function(*self.args, **self.kwargs):
11831183
break

0 commit comments

Comments
 (0)