Skip to content

Commit 1f4f28c

Browse files
bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (GH-17437)
Make ssl tests less strict and also accept TLSv3 as the default maximum version. This change unbreaks test_min_max_version on Fedora 32. https://bugs.python.org/issue38815 (cherry picked from commit 34864d1) Co-authored-by: torsava <[email protected]>
1 parent 926eabb commit 1f4f28c

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

Lib/test/test_ssl.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1220,12 +1220,18 @@ def test_min_max_version(self):
12201220
# RHEL 8 uses TLS 1.2 by default
12211221
ssl.TLSVersion.TLSv1_2
12221222
}
1223+
maximum_range = {
1224+
# stock OpenSSL
1225+
ssl.TLSVersion.MAXIMUM_SUPPORTED,
1226+
# Fedora 32 uses TLS 1.3 by default
1227+
ssl.TLSVersion.TLSv1_3
1228+
}
12231229

12241230
self.assertIn(
12251231
ctx.minimum_version, minimum_range
12261232
)
1227-
self.assertEqual(
1228-
ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED
1233+
self.assertIn(
1234+
ctx.maximum_version, maximum_range
12291235
)
12301236

12311237
ctx.minimum_version = ssl.TLSVersion.TLSv1_1

0 commit comments

Comments
 (0)