Skip to content

Commit 1fc5de9

Browse files
committed
backport of bpo-30624 / PR #2082 for python 3.6
1 parent 59422a2 commit 1fc5de9

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Lib/selectors.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ def register(self, fileobj, events, data=None):
410410
epoll_events |= select.EPOLLOUT
411411
try:
412412
self._epoll.register(key.fd, epoll_events)
413-
except BaseException:
413+
except:
414414
super().unregister(fileobj)
415415
raise
416416
return key
@@ -543,7 +543,7 @@ def register(self, fileobj, events, data=None):
543543
kev = select.kevent(key.fd, select.KQ_FILTER_WRITE,
544544
select.KQ_EV_ADD)
545545
self._kqueue.control([kev], 0, 0)
546-
except BaseException:
546+
except:
547547
super().unregister(fileobj)
548548
raise
549549
return key

Misc/NEWS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ Core and Builtins
4949
Library
5050
-------
5151

52+
- bpo-30624: selectors does not take KeyboardInterrupt and SystemExit into
53+
account, leaving a fd in a bad state in case of error. Patch by Giampaolo
54+
Rodola'.
55+
5256
- bpo-28556: Updates to typing module: Add generic AsyncContextManager, add
5357
support for ContextManager on all versions. Original PRs by Jelle Zijlstra
5458
and Ivan Levkivskyi

0 commit comments

Comments
 (0)