Skip to content

Commit 240eb9a

Browse files
committed
check cache keys directly, not count
1 parent 8efe040 commit 240eb9a

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

Lib/test/test_linecache.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -253,28 +253,32 @@ def setUp(self):
253253
self.addCleanup(os_helper.unlink, fname)
254254
with open(fname, 'w', encoding='utf-8') as source:
255255
source.write(f'print("I am {fname}")')
256+
257+
self.assertNotIn(fname, linecache.cache)
256258
linecache.getlines(fname)
259+
self.assertIn(fname, linecache.cache)
257260

258261
os.remove(self.deleted_file)
259262
with open(self.modified_file, 'w', encoding='utf-8') as source:
260263
source.write('print("was modified")')
261264

262265
def test_checkcache_for_deleted_file(self):
263-
self.assertEqual(3, len(linecache.cache.keys()))
264266
linecache.checkcache(self.deleted_file)
265-
self.assertEqual(2, len(linecache.cache.keys()))
266-
self.assertNotIn(self.deleted_file, linecache.cache.keys())
267+
self.assertNotIn(self.deleted_file, linecache.cache)
268+
self.assertIn(self.modified_file, linecache.cache)
269+
self.assertIn(self.unchanged_file, linecache.cache)
267270

268271
def test_checkcache_for_modified_file(self):
269-
self.assertEqual(3, len(linecache.cache.keys()))
270272
linecache.checkcache(self.modified_file)
271-
self.assertEqual(2, len(linecache.cache.keys()))
272-
self.assertNotIn(self.modified_file, linecache.cache.keys())
273+
self.assertIn(self.deleted_file, linecache.cache)
274+
self.assertNotIn(self.modified_file, linecache.cache)
275+
self.assertIn(self.unchanged_file, linecache.cache)
273276

274277
def test_checkcache_with_no_parameter(self):
275-
self.assertEqual(3, len(linecache.cache.keys()))
276278
linecache.checkcache()
277-
self.assertEqual([self.unchanged_file], list(linecache.cache.keys()))
279+
self.assertNotIn(self.deleted_file, linecache.cache)
280+
self.assertNotIn(self.modified_file, linecache.cache)
281+
self.assertIn(self.unchanged_file, linecache.cache)
278282

279283

280284
if __name__ == "__main__":

0 commit comments

Comments
 (0)