Skip to content

Commit 253c8eb

Browse files
bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943)
(cherry picked from commit c579ad1) Co-authored-by: Mark Roseman <[email protected]>
1 parent c1b620e commit 253c8eb

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

Lib/idlelib/configdialog.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ def __init__(self, parent, title='', *, _htest=False, _utest=False):
6767
if not _utest:
6868
self.withdraw()
6969

70-
self.configure(borderwidth=5)
7170
self.title(title or 'IDLE Preferences')
7271
x = parent.winfo_rootx() + 20
7372
y = parent.winfo_rooty() + (30 if not _htest else 150)
@@ -97,6 +96,7 @@ def create_widgets(self):
9796
"""Create and place widgets for tabbed dialog.
9897
9998
Widgets Bound to self:
99+
frame: encloses all other widgets
100100
note: Notebook
101101
highpage: HighPage
102102
fontpage: FontPage
@@ -109,7 +109,9 @@ def create_widgets(self):
109109
load_configs: Load pages except for extensions.
110110
activate_config_changes: Tell editors to reload.
111111
"""
112-
self.note = note = Notebook(self)
112+
self.frame = frame = Frame(self, padding="5px")
113+
self.frame.grid(sticky="nwes")
114+
self.note = note = Notebook(frame)
113115
self.highpage = HighPage(note)
114116
self.fontpage = FontPage(note, self.highpage)
115117
self.keyspage = KeysPage(note)
@@ -148,7 +150,7 @@ def create_action_buttons(self):
148150
padding_args = {}
149151
else:
150152
padding_args = {'padding': (6, 3)}
151-
outer = Frame(self, padding=2)
153+
outer = Frame(self.frame, padding=2)
152154
buttons_frame = Frame(outer, padding=2)
153155
self.buttons = {}
154156
for txt, cmd in (
@@ -687,7 +689,7 @@ class HighPage(Frame):
687689

688690
def __init__(self, master):
689691
super().__init__(master)
690-
self.cd = master.master
692+
self.cd = master.winfo_toplevel()
691693
self.style = Style(master)
692694
self.create_page_highlight()
693695
self.load_theme_cfg()
@@ -1346,7 +1348,7 @@ class KeysPage(Frame):
13461348

13471349
def __init__(self, master):
13481350
super().__init__(master)
1349-
self.cd = master.master
1351+
self.cd = master.winfo_toplevel()
13501352
self.create_page_keys()
13511353
self.load_key_cfg()
13521354

0 commit comments

Comments
 (0)