Skip to content

Commit 256faf8

Browse files
committed
bpo-46358: modernize test_asyncio/test_base_events.py
1 parent 0bbf30e commit 256faf8

File tree

2 files changed

+9
-20
lines changed

2 files changed

+9
-20
lines changed

Lib/test/test_asyncio/test_base_events.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222

2323
MOCK_ANY = mock.ANY
24-
PY34 = sys.version_info >= (3, 4)
2524

2625

2726
def tearDownModule():
@@ -596,18 +595,11 @@ async def zero_error_coro():
596595
self.loop.run_forever()
597596
fut = None # Trigger Future.__del__ or futures._TracebackLogger
598597
support.gc_collect()
599-
if PY34:
600-
# Future.__del__ in Python 3.4 logs error with
601-
# an actual exception context
602-
log.error.assert_called_with(
603-
test_utils.MockPattern('.*exception was never retrieved'),
604-
exc_info=(ZeroDivisionError, MOCK_ANY, MOCK_ANY))
605-
else:
606-
# futures._TracebackLogger logs only textual traceback
607-
log.error.assert_called_with(
608-
test_utils.MockPattern(
609-
'.*exception was never retrieved.*ZeroDiv'),
610-
exc_info=False)
598+
# Future.__del__ in Python 3.4 logs error with
599+
# an actual exception context
600+
log.error.assert_called_with(
601+
test_utils.MockPattern('.*exception was never retrieved'),
602+
exc_info=(ZeroDivisionError, MOCK_ANY, MOCK_ANY))
611603

612604
def test_set_exc_handler_invalid(self):
613605
with self.assertRaisesRegex(TypeError, 'A callable object or None'):

Lib/test/test_asyncio/test_futures.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -571,13 +571,10 @@ def memory_error():
571571
test_utils.run_briefly(self.loop)
572572
support.gc_collect()
573573

574-
if sys.version_info >= (3, 4):
575-
regex = f'^{self.cls.__name__} exception was never retrieved\n'
576-
exc_info = (type(exc), exc, exc.__traceback__)
577-
m_log.error.assert_called_once_with(mock.ANY, exc_info=exc_info)
578-
else:
579-
regex = r'^Future/Task exception was never retrieved\n'
580-
m_log.error.assert_called_once_with(mock.ANY, exc_info=False)
574+
regex = f'^{self.cls.__name__} exception was never retrieved\n'
575+
exc_info = (type(exc), exc, exc.__traceback__)
576+
m_log.error.assert_called_once_with(mock.ANY, exc_info=exc_info)
577+
581578
message = m_log.error.call_args[0][0]
582579
self.assertRegex(message, re.compile(regex, re.DOTALL))
583580

0 commit comments

Comments
 (0)