closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)

Alexey Izbyshev · benjaminp · commit 2b824b2538c4 · 2018-08-23T21:27:52.000-07:00
Reported by Svace static analyzer.
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -2401,6 +2401,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                 }
             }
             result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
             temp = PyNumber_Add(result, item);
             Py_DECREF(result);
             Py_DECREF(item);

Original file line number	Diff line number	Diff line change
`@@ -2401,6 +2401,11 @@ builtin_sum_impl(PyObject module, PyObject iterable, PyObject *start)`
`2401`	`2401`	`}`
`2402`	`2402`	`}`
`2403`	`2403`	`result = PyFloat_FromDouble(f_result);`
	`2404`	`+ if (result == NULL) {`
	`2405`	`+ Py_DECREF(item);`
	`2406`	`+ Py_DECREF(iter);`
	`2407`	`+ return NULL;`
	`2408`	`+ }`
`2404`	`2409`	`temp = PyNumber_Add(result, item);`
`2405`	`2410`	`Py_DECREF(result);`
`2406`	`2411`	`Py_DECREF(item);`