closes bpo-35139: The pyexpat module's macros in Modules/Setup now match setup.py (GH-10289)

maxbelanger · benjaminp · commit 318ab63c01f5 · 2018-11-01T19:49:46.000-07:00
This could cause compile errors on macOS or other platforms.
diff --git a/Misc/NEWS.d/next/Build/2018-11-01-15-01-23.bpo-35139.XZTttb.rst b/Misc/NEWS.d/next/Build/2018-11-01-15-01-23.bpo-35139.XZTttb.rst
@@ -0,0 +1 @@
+Fix a compiler error when statically linking `pyexpat` in `Modules/Setup`.
diff --git a/Modules/Setup b/Modules/Setup
@@ -336,7 +336,7 @@ _symtable symtablemodule.c
 # Interface to the Expat XML parser
 # More information on Expat can be found at www.libexpat.org.
 #
-#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DUSE_PYEXPAT_CAPI
+#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI
 
 # Hye-Shik Chang's CJKCodecs
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix a compiler error when statically linking `pyexpat` in `Modules/Setup`.
Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ _symtable symtablemodule.c`
`336`	`336`	`# Interface to the Expat XML parser`
`337`	`337`	`# More information on Expat can be found at www.libexpat.org.`
`338`	`338`	`#`
`339`		`-#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DUSE_PYEXPAT_CAPI`
	`339`	`+#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI`
`340`	`340`
`341`	`341`	`# Hye-Shik Chang's CJKCodecs`
`342`	`342`