Fix Windows test_mmap -- by removing BUILD_SLICE/STORE_SLICE

gvanrossum · gvanrossum · commit 44a1ffc6d4a6 · 2023-06-25T21:12:56.000-07:00
diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/opcode_metadata.h b/Python/opcode_metadata.h
@@ -1135,8 +1135,6 @@ const struct opcode_macro_expansion _PyOpcode_macro_expansion[256] = {
     [UNARY_NEGATIVE] = { .nuops = 1, .uops = { { UNARY_NEGATIVE, 0, 0 } } },
     [UNARY_NOT] = { .nuops = 1, .uops = { { UNARY_NOT, 0, 0 } } },
     [UNARY_INVERT] = { .nuops = 1, .uops = { { UNARY_INVERT, 0, 0 } } },
-    [BINARY_SLICE] = { .nuops = 1, .uops = { { BINARY_SLICE, 0, 0 } } },
-    [STORE_SLICE] = { .nuops = 1, .uops = { { STORE_SLICE, 0, 0 } } },
     [BINARY_SUBSCR_LIST_INT] = { .nuops = 1, .uops = { { BINARY_SUBSCR_LIST_INT, 0, 0 } } },
     [BINARY_SUBSCR_TUPLE_INT] = { .nuops = 1, .uops = { { BINARY_SUBSCR_TUPLE_INT, 0, 0 } } },
     [BINARY_SUBSCR_DICT] = { .nuops = 1, .uops = { { BINARY_SUBSCR_DICT, 0, 0 } } },
diff --git a/Tools/cases_generator/generate_cases.py b/Tools/cases_generator/generate_cases.py
@@ -314,6 +314,7 @@ def emit_macros(cls, out: Formatter):
     "import_from",
     "import_name",
     "_PyObject_CallNoArgs",  # Proxy for BEFORE_WITH
+    "_PyBuildSlice_ConsumeRefs",  # Proxy for BINARY_SLICE, STORE_SLICE
 )
 
 

Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,7 @@ def emit_macros(cls, out: Formatter):`
`314`	`314`	`"import_from",`
`315`	`315`	`"import_name",`
`316`	`316`	`"_PyObject_CallNoArgs", # Proxy for BEFORE_WITH`
	`317`	`+ "_PyBuildSlice_ConsumeRefs", # Proxy for BINARY_SLICE, STORE_SLICE`
`317`	`318`	`)`
`318`	`319`
`319`	`320`