Skip to content

Commit 45ffab4

Browse files
gh-97966: Restore prior expectation that uname_result._fields and ._asdict would include the processor. (gh-98343)
(cherry picked from commit dc063a2) Co-authored-by: Jason R. Coombs <[email protected]>
1 parent 3e3980b commit 45ffab4

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

Lib/platform.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -785,6 +785,8 @@ class uname_result(
785785
except when needed.
786786
"""
787787

788+
_fields = ('system', 'node', 'release', 'version', 'machine', 'processor')
789+
788790
@functools.cached_property
789791
def processor(self):
790792
return _unknown_as_blank(_Processor.get())
@@ -798,7 +800,7 @@ def __iter__(self):
798800
@classmethod
799801
def _make(cls, iterable):
800802
# override factory to affect length check
801-
num_fields = len(cls._fields)
803+
num_fields = len(cls._fields) - 1
802804
result = cls.__new__(cls, *iterable)
803805
if len(result) != num_fields + 1:
804806
msg = f'Expected {num_fields} arguments, got {len(result)}'
@@ -812,7 +814,7 @@ def __len__(self):
812814
return len(tuple(iter(self)))
813815

814816
def __reduce__(self):
815-
return uname_result, tuple(self)[:len(self._fields)]
817+
return uname_result, tuple(self)[:len(self._fields) - 1]
816818

817819

818820
_uname_cache = None

Lib/test/test_platform.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,14 @@ def test_uname_slices(self):
269269
self.assertEqual(res[:], expected)
270270
self.assertEqual(res[:5], expected[:5])
271271

272+
def test_uname_fields(self):
273+
self.assertIn('processor', platform.uname()._fields)
274+
275+
def test_uname_asdict(self):
276+
res = platform.uname()._asdict()
277+
self.assertEqual(len(res), 6)
278+
self.assertIn('processor', res)
279+
272280
@unittest.skipIf(sys.platform in ['win32', 'OpenVMS'], "uname -p not used")
273281
@support.requires_subprocess()
274282
def test_uname_processor(self):
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
On ``uname_result``, restored expectation that ``_fields`` and ``_asdict``
2+
would include all six properties including ``processor``.

0 commit comments

Comments
 (0)