Skip to content

Commit 485e715

Browse files
authored
bpo-40287: Fix SpooledTemporaryFile.seek() return value (GH-19540)
It has not returned the file position after the seek.
1 parent bf1a812 commit 485e715

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Lib/tempfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ def readlines(self, *args):
738738
return self._file.readlines(*args)
739739

740740
def seek(self, *args):
741-
self._file.seek(*args)
741+
return self._file.seek(*args)
742742

743743
def tell(self):
744744
return self._file.tell()

Lib/test/test_tempfile.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,8 @@ def test_writelines(self):
10181018
# Verify writelines with a SpooledTemporaryFile
10191019
f = self.do_create()
10201020
f.writelines((b'x', b'y', b'z'))
1021-
f.seek(0)
1021+
pos = f.seek(0)
1022+
self.assertEqual(pos, 0)
10221023
buf = f.read()
10231024
self.assertEqual(buf, b'xyz')
10241025

@@ -1036,7 +1037,8 @@ def test_sparse(self):
10361037
# when that occurs
10371038
f = self.do_create(max_size=30)
10381039
self.assertFalse(f._rolled)
1039-
f.seek(100, 0)
1040+
pos = f.seek(100, 0)
1041+
self.assertEqual(pos, 100)
10401042
self.assertFalse(f._rolled)
10411043
f.write(b'x')
10421044
self.assertTrue(f._rolled)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed ``SpooledTemporaryFile.seek()`` to return the position.

0 commit comments

Comments
 (0)