Skip to content

Commit 4fc02af

Browse files
Use PyModule_AddIntMacro in PyInit__signal()
1 parent 6955d44 commit 4fc02af

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

Modules/signalmodule.c

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,21 +1346,19 @@ PyInit__signal(void)
13461346
initialized = 1;
13471347
#endif
13481348

1349-
/* Add some symbolic constants to the module */
13501349
d = PyModule_GetDict(m);
13511350

13521351
x = DefaultHandler = PyLong_FromVoidPtr((void *)SIG_DFL);
1353-
if (!x || PyDict_SetItemString(d, "SIG_DFL", x) < 0)
1354-
goto finally;
1352+
if (PyModule_AddObject(m, "SIG_DFL", x))
1353+
goto finally;
13551354

13561355
x = IgnoreHandler = PyLong_FromVoidPtr((void *)SIG_IGN);
1357-
if (!x || PyDict_SetItemString(d, "SIG_IGN", x) < 0)
1358-
goto finally;
1356+
if (PyModule_AddObject(m, "SIG_IGN", x))
1357+
goto finally;
13591358

13601359
x = PyLong_FromLong((long)NSIG);
1361-
if (!x || PyDict_SetItemString(d, "NSIG", x) < 0)
1362-
goto finally;
1363-
Py_DECREF(x);
1360+
if (PyModule_AddObject(m, "NSIG", x))
1361+
goto finally;
13641362

13651363
#ifdef SIG_BLOCK
13661364
if (PyModule_AddIntMacro(m, SIG_BLOCK))
@@ -1569,8 +1567,8 @@ PyInit__signal(void)
15691567
#if defined (HAVE_SETITIMER) || defined (HAVE_GETITIMER)
15701568
ItimerError = PyErr_NewException("signal.ItimerError",
15711569
PyExc_OSError, NULL);
1572-
if (ItimerError != NULL)
1573-
PyDict_SetItemString(d, "ItimerError", ItimerError);
1570+
if (PyModule_AddObject(m, "ItimerError", ItimerError))
1571+
goto finally;
15741572
#endif
15751573

15761574
#ifdef CTRL_C_EVENT

0 commit comments

Comments
 (0)