remove assignment in conditional

benjaminp · benjaminp · commit 4fd929b43121 · 2015-04-01T11:16:40.000-04:00
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
@@ -5268,7 +5268,8 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
         goto err;
     }
 
-    if ((all = PyList_New(0)) == NULL)
+    all = PyList_New(0);
+    if (all == NULL)
         goto err;
     for (res = res0; res; res = res->ai_next) {
         PyObject *single;

Original file line number	Diff line number	Diff line change
`@@ -5268,7 +5268,8 @@ socket_getaddrinfo(PyObject self, PyObject args, PyObject* kwargs)`
`5268`	`5268`	`goto err;`
`5269`	`5269`	`}`
`5270`	`5270`
`5271`		`- if ((all = PyList_New(0)) == NULL)`
	`5271`	`+ all = PyList_New(0);`
	`5272`	`+ if (all == NULL)`
`5272`	`5273`	`goto err;`
`5273`	`5274`	`for (res = res0; res; res = res->ai_next) {`
`5274`	`5275`	`PyObject *single;`