bpo-43358: Fix bad free in assemble function (GH-24697)

alexhenrie · web-flow · commit 503627fc2acb · 2021-03-02T10:20:25.000Z
diff --git a/Python/compile.c b/Python/compile.c
@@ -6664,12 +6664,12 @@ assemble(struct compiler *c, int addNone)
 
     for (basicblock *b = c->u->u_blocks; b != NULL; b = b->b_list) {
         if (normalize_basic_block(b)) {
-            goto error;
+            return NULL;
         }
     }
 
     if (ensure_exits_have_lineno(c)) {
-        goto error;
+        return NULL;
     }
 
     nblocks = 0;

Original file line number	Diff line number	Diff line change
`@@ -6664,12 +6664,12 @@ assemble(struct compiler *c, int addNone)`
`6664`	`6664`
`6665`	`6665`	`for (basicblock *b = c->u->u_blocks; b != NULL; b = b->b_list) {`
`6666`	`6666`	`if (normalize_basic_block(b)) {`
`6667`		`- goto error;`
	`6667`	`+ return NULL;`
`6668`	`6668`	`}`
`6669`	`6669`	`}`
`6670`	`6670`
`6671`	`6671`	`if (ensure_exits_have_lineno(c)) {`
`6672`		`- goto error;`
	`6672`	`+ return NULL;`
`6673`	`6673`	`}`
`6674`	`6674`
`6675`	`6675`	`nblocks = 0;`