Skip to content

Commit 5765eaa

Browse files
bpo-46616: Ensures test_importlib.test_windows cleans up registry keys after completion (GH-31086)
(cherry picked from commit 89a0a90) Co-authored-by: Steve Dower <[email protected]>
1 parent ba4d79a commit 5765eaa

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

Lib/test/test_importlib/test_windows.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,28 @@ def setup_module(machinery, name, path=None):
6161
root = machinery.WindowsRegistryFinder.REGISTRY_KEY
6262
key = root.format(fullname=name,
6363
sys_version='%d.%d' % sys.version_info[:2])
64+
base_key = "Software\\Python\\PythonCore\\{}.{}".format(
65+
sys.version_info.major, sys.version_info.minor)
66+
assert key.casefold().startswith(base_key.casefold()), (
67+
"expected key '{}' to start with '{}'".format(key, base_key))
6468
try:
6569
with temp_module(name, "a = 1") as location:
70+
try:
71+
OpenKey(HKEY_CURRENT_USER, base_key)
72+
if machinery.WindowsRegistryFinder.DEBUG_BUILD:
73+
delete_key = os.path.dirname(key)
74+
else:
75+
delete_key = key
76+
except OSError:
77+
delete_key = base_key
6678
subkey = CreateKey(HKEY_CURRENT_USER, key)
6779
if path is None:
6880
path = location + ".py"
6981
SetValue(subkey, "", REG_SZ, path)
7082
yield
7183
finally:
72-
if machinery.WindowsRegistryFinder.DEBUG_BUILD:
73-
key = os.path.dirname(key)
74-
delete_registry_tree(HKEY_CURRENT_USER, key)
84+
if delete_key:
85+
delete_registry_tree(HKEY_CURRENT_USER, delete_key)
7586

7687

7788
@unittest.skipUnless(sys.platform.startswith('win'), 'requires Windows')
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Ensures ``test_importlib.test_windows`` cleans up registry keys after
2+
completion.

0 commit comments

Comments
 (0)