Skip to content

Commit 5b95a15

Browse files
gnpricebenjaminp
authored andcommitted
bpo-35518: Skip test that relies on a deceased network service. (GH-15349)
If this service had thoroughly vanished, we could just ignore the test until someone gets around to either recreating such a service or redesigning the test to somehow work locally. The `support.transient_internet` mechanism catches the failure to resolve the domain name, and skips the test. But in fact the domain snakebite.net does still exist, as do its nameservers -- and they can be quite slow to reply. As a result this test can easily take 20-30s before it gets auto-skipped. So, skip the test explicitly up front.
1 parent d33e46d commit 5b95a15

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Lib/test/test_timeout.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ def setUp(self):
150150
def tearDown(self):
151151
self.sock.close()
152152

153+
@unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
153154
def testConnectTimeout(self):
154155
# Testing connect timeout is tricky: we need to have IP connectivity
155156
# to a host that silently drops our packets. We can't simulate this

0 commit comments

Comments
 (0)