Skip to content

Commit 6356a3b

Browse files
authored
Remove catching OSError in ftphandler test. Only URLError is raised in urllib.request module. (#918) (#921)
(cherry picked from commit ed3dd1c)
1 parent 9273dfe commit 6356a3b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

Lib/test/test_urllib2.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,6 @@ def test_file(self):
826826
for url, ftp in [
827827
("file://ftp.example.com//foo.txt", False),
828828
("file://ftp.example.com///foo.txt", False),
829-
# XXXX bug: fails with OSError, should be URLError
830829
("file://ftp.example.com/foo.txt", False),
831830
("file://somehost//foo/something.txt", False),
832831
("file://localhost//foo/something.txt", False),
@@ -835,7 +834,7 @@ def test_file(self):
835834
try:
836835
h.file_open(req)
837836
# XXXX remove OSError when bug fixed
838-
except (urllib.error.URLError, OSError):
837+
except urllib.error.URLError:
839838
self.assertFalse(ftp)
840839
else:
841840
self.assertIs(o.req, req)
@@ -1616,7 +1615,6 @@ def test_invalid_closed(self):
16161615
self.assertTrue(conn.fakesock.closed, "Connection not closed")
16171616

16181617

1619-
16201618
class MiscTests(unittest.TestCase):
16211619

16221620
def opener_has_handler(self, opener, handler_class):

0 commit comments

Comments
 (0)