[2.7] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16176)

zhangyangyu · web-flow · commit 68d8c122972d · 2019-09-16T15:07:32.000+08:00
(cherry picked from commit 56a4514) Co-authored-by: Hai Shi shihai1992@gmail.com https://bugs.python.org/issue38168
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
@@ -1436,7 +1436,8 @@ static void
 setint(PyObject *d, const char *name, long value)
 {
     PyObject *o = PyInt_FromLong(value);
-    if (o && PyDict_SetItemString(d, name, o) == 0) {
+    if (o) {
+        PyDict_SetItemString(d, name, o);
         Py_DECREF(o);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1436,7 +1436,8 @@ static void`
`1436`	`1436`	`setint(PyObject d, const char name, long value)`
`1437`	`1437`	`{`
`1438`	`1438`	`PyObject *o = PyInt_FromLong(value);`
`1439`		`- if (o && PyDict_SetItemString(d, name, o) == 0) {`
	`1439`	`+ if (o) {`
	`1440`	`+ PyDict_SetItemString(d, name, o);`
`1440`	`1441`	`Py_DECREF(o);`
`1441`	`1442`	`}`
`1442`	`1443`	`}`