Skip to content

Commit 6c2601d

Browse files
committed
Get rid of check_overlaps()
As Brandt pointed out in a code review, it is unnecessary.
1 parent 6d18932 commit 6c2601d

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

Tools/cases_generator/generate_cases.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,6 @@ def __init__(self, inst: parser.InstDef):
5353
]
5454
self.output_effects = self.outputs # For consistency/completeness
5555

56-
def check_overlaps(self, psr: parser.Parser) -> None:
57-
for i, inp in enumerate(self.input_effects):
58-
for j, outp in enumerate(self.output_effects):
59-
if inp.name == outp.name and inp.name != "unused":
60-
if i != j:
61-
tkn = psr.tokens[ctx.begin] if (ctx := self.context) else None
62-
raise psr.make_syntax_error(
63-
f"Input {inp.name!r} at pos {i} repeated in output at different pos {j}",
64-
tkn,
65-
)
66-
break
67-
6856
def write(self, f: typing.TextIO, indent: str, dedent: int = 0) -> None:
6957
"""Write one instruction, sans prologue and epilogue."""
7058
if dedent < 0:
@@ -267,7 +255,6 @@ def parse(self) -> None:
267255
while (tkn := psr.peek(raw=True)) and tkn.text != END_MARKER:
268256
if inst := psr.inst_def():
269257
self.instrs[inst.name] = instr = Instruction(inst)
270-
instr.check_overlaps(psr)
271258
elif super := psr.super_def():
272259
self.supers[super.name] = super
273260
elif family := psr.family_def():

0 commit comments

Comments
 (0)