Nitpick

Author: Erlend E. Aasland

configure

@@ -5668,7 +5668,7 @@ if ${ac_cv_wl_no_as_needed+:} false; then :
 else
 
   save_LDFLAGS="$LDFLAGS"
-  LDFLAGS="$LDFLAGS -Wl,--no-as-needed"
+  as_fn_append LDFLAGS -Wl,--no-as-needed
   cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 

configure.ac

@@ -899,12 +899,12 @@ AC_SUBST(MULTIARCH_CPPFLAGS)
 
 AC_CACHE_CHECK([for -Wl,--no-as-needed], [ac_cv_wl_no_as_needed], [
   save_LDFLAGS="$LDFLAGS"
-  LDFLAGS="$LDFLAGS -Wl,--no-as-needed"
+  AS_VAR_APPEND([LDFLAGS], [-Wl,--no-as-needed])
   AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
     [NO_AS_NEEDED="-Wl,--no-as-needed"
-     AS_VAR_SET([ac_cv_wl_no_as_needed], [yes])],
+     ac_cv_wl_no_as_needed=yes],
     [NO_AS_NEEDED=""
-     AS_VAR_SET([ac_cv_wl_no_as_needed], [no])])
+     ac_cv_wl_no_as_needed=no])
   LDFLAGS="$save_LDFLAGS"
 ])
 AC_SUBST(NO_AS_NEEDED)