Skip to content

Commit 789f95a

Browse files
[2.7] Fixed several assertTrue() that were intended to be assertEqual(). (GH-8191) (GH-8202)
Fixed also testing the "always" warning filter. (cherry picked from commit b796e7d) Co-authored-by: Sergey Fedoseev <[email protected]>
1 parent b1e6e56 commit 789f95a

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

Lib/ctypes/test/test_as_parameter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_wchar_parm(self):
2424
f.argtypes = [c_byte, c_wchar, c_int, c_long, c_float, c_double]
2525
result = f(self.wrap(1), self.wrap(u"x"), self.wrap(3), self.wrap(4), self.wrap(5.0), self.wrap(6.0))
2626
self.assertEqual(result, 139)
27-
self.assertTrue(type(result), int)
27+
self.assertIs(type(result), int)
2828

2929
def test_pointers(self):
3030
f = dll._testfunc_p_p

Lib/test/test_pkg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def test_2(self):
134134

135135
s = """
136136
from t2 import *
137-
self.assertTrue(dir(), ['self', 'sub'])
137+
self.assertEqual(dir(), ['self', 'sub'])
138138
"""
139139
self.run_code(s)
140140

Lib/test/test_test_support.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def test_temp_cwd(self):
267267
with support.temp_cwd(name=TESTFN):
268268
self.assertEqual(os.path.basename(os.getcwd()), TESTFN)
269269
self.assertFalse(os.path.exists(TESTFN))
270-
self.assertTrue(os.path.basename(os.getcwd()), here)
270+
self.assertEqual(os.getcwd(), here)
271271

272272

273273
def test_temp_cwd__name_none(self):

Lib/test/test_warnings.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,14 @@ def test_always(self):
107107
self.module.resetwarnings()
108108
self.module.filterwarnings("always", category=UserWarning)
109109
message = "FilterTests.test_always"
110-
self.module.warn(message, UserWarning)
111-
self.assertTrue(message, w[-1].message)
112-
self.module.warn(message, UserWarning)
113-
self.assertTrue(w[-1].message, message)
110+
def f():
111+
self.module.warn(message, UserWarning)
112+
f()
113+
self.assertEqual(len(w), 1)
114+
self.assertEqual(w[-1].message.args[0], message)
115+
f()
116+
self.assertEqual(len(w), 2)
117+
self.assertEqual(w[-1].message.args[0], message)
114118

115119
def test_default(self):
116120
with original_warnings.catch_warnings(record=True,

0 commit comments

Comments
 (0)