Skip to content

Commit 82b395c

Browse files
Drop the _PyCrossInterpreterData_Clear() call in _xxsubinterpreters.
1 parent 1827feb commit 82b395c

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

Modules/_xxsubinterpretersmodule.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,7 @@ _release_xid_data(_PyCrossInterpreterData *data, int ignoreexc)
6767
}
6868
int res = _PyCrossInterpreterData_Release(data);
6969
if (res < 0) {
70-
// XXX Fix this!
71-
/* The owning interpreter is already destroyed.
72-
* Ideally, this shouldn't ever happen. (It's highly unlikely.)
73-
* For now we hack around that to resolve refleaks, by decref'ing
74-
* the released object here, even if its the wrong interpreter.
75-
* The owning interpreter has already been destroyed
76-
* so we should be okay, especially since the currently
77-
* shareable types are all very basic, with no GC.
78-
* That said, it becomes much messier once interpreters
79-
* no longer share a GIL, so this needs to be fixed before then. */
70+
/* The owning interpreter is already destroyed. */
8071
_PyCrossInterpreterData_Clear(NULL, data);
8172
if (ignoreexc) {
8273
// XXX Emit a warning?

0 commit comments

Comments
 (0)