gh-100256: Skip inaccessible registry keys in the WinAPI mimetype implementation (GH-122047)

miss-islington · LucasEsposito · web-flow · commit 8f4892ac529b · 2024-08-07T19:39:51.000+01:00
(cherry picked from commit 0bd9375) Co-authored-by: Lucas Esposito <LucasEsposito@users.noreply.github.com>
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -516,6 +516,7 @@ Michael Ernst
 Ben Escoto
 Andy Eskilsson
 André Espaze
+Lucas Esposito
 Stefan Esser
 Nicolas Estibals
 Jonathan Eunice
diff --git a/Misc/NEWS.d/next/Windows/2024-07-19-21-50-54.gh-issue-100256.GDrKba.rst b/Misc/NEWS.d/next/Windows/2024-07-19-21-50-54.gh-issue-100256.GDrKba.rst
@@ -0,0 +1 @@
+:mod:`mimetypes` no longer fails when it encounters an inaccessible registry key.
diff --git a/Modules/_winapi.c b/Modules/_winapi.c
@@ -2268,7 +2268,7 @@ _winapi__mimetypes_read_windows_registry_impl(PyObject *module,
         }
 
         err = RegOpenKeyExW(hkcr, ext, 0, KEY_READ, &subkey);
-        if (err == ERROR_FILE_NOT_FOUND) {
+        if (err == ERROR_FILE_NOT_FOUND || err == ERROR_ACCESS_DENIED) {
             err = ERROR_SUCCESS;
             continue;
         } else if (err != ERROR_SUCCESS) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+:mod:`mimetypes` no longer fails when it encounters an inaccessible registry key.
Original file line number	Diff line number	Diff line change
`@@ -2268,7 +2268,7 @@ _winapi__mimetypes_read_windows_registry_impl(PyObject *module,`
`2268`	`2268`	`}`
`2269`	`2269`
`2270`	`2270`	`err = RegOpenKeyExW(hkcr, ext, 0, KEY_READ, &subkey);`
`2271`		`- if (err == ERROR_FILE_NOT_FOUND) {`
	`2271`	`+ if (err == ERROR_FILE_NOT_FOUND \|\| err == ERROR_ACCESS_DENIED) {`
`2272`	`2272`	`err = ERROR_SUCCESS;`
`2273`	`2273`	`continue;`
`2274`	`2274`	`} else if (err != ERROR_SUCCESS) {`