Skip to content

Commit 9495bca

Browse files
authored
gh-111277: In summarize_stats.py, don't fail fast on invalid ratios (#111278)
1 parent 84b4533 commit 9495bca

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Tools/scripts/summarize_stats.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,8 +421,6 @@ def __init__(self, num: int, den: int | None, percentage: bool = True):
421421
self.num = num
422422
self.den = den
423423
self.percentage = percentage
424-
if den == 0 and num != 0:
425-
raise ValueError("Invalid denominator")
426424

427425
def __float__(self):
428426
if self.den == 0:
@@ -433,7 +431,11 @@ def __float__(self):
433431
return self.num / self.den
434432

435433
def markdown(self) -> str:
436-
if self.den == 0 or self.den is None:
434+
if self.den is None:
435+
return ""
436+
elif self.den == 0:
437+
if self.num != 0:
438+
return f"{self.num:,} / 0 !!"
437439
return ""
438440
elif self.percentage:
439441
return f"{self.num / self.den:,.01%}"

0 commit comments

Comments
 (0)