Skip to content

Commit 9541bd3

Browse files
nanjekyejoannahberkerpeksag
authored andcommitted
bpo-24011: Use PyModule_Add{Object,IntMacro} in PyInit__signal() (GH-12765)
1 parent 5ebfa84 commit 9541bd3

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

Modules/signalmodule.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1350,17 +1350,15 @@ PyInit__signal(void)
13501350
d = PyModule_GetDict(m);
13511351

13521352
x = DefaultHandler = PyLong_FromVoidPtr((void *)SIG_DFL);
1353-
if (!x || PyDict_SetItemString(d, "SIG_DFL", x) < 0)
1353+
if (PyModule_AddObject(m, "SIG_DFL", x))
13541354
goto finally;
13551355

13561356
x = IgnoreHandler = PyLong_FromVoidPtr((void *)SIG_IGN);
1357-
if (!x || PyDict_SetItemString(d, "SIG_IGN", x) < 0)
1357+
if (PyModule_AddObject(m, "SIG_IGN", x))
13581358
goto finally;
13591359

1360-
x = PyLong_FromLong((long)NSIG);
1361-
if (!x || PyDict_SetItemString(d, "NSIG", x) < 0)
1360+
if (PyModule_AddIntMacro(m, NSIG))
13621361
goto finally;
1363-
Py_DECREF(x);
13641362

13651363
#ifdef SIG_BLOCK
13661364
if (PyModule_AddIntMacro(m, SIG_BLOCK))
@@ -1569,8 +1567,8 @@ PyInit__signal(void)
15691567
#if defined (HAVE_SETITIMER) || defined (HAVE_GETITIMER)
15701568
ItimerError = PyErr_NewException("signal.ItimerError",
15711569
PyExc_OSError, NULL);
1572-
if (ItimerError != NULL)
1573-
PyDict_SetItemString(d, "ItimerError", ItimerError);
1570+
if (PyModule_AddObject(m, "ItimerError", ItimerError))
1571+
goto finally;
15741572
#endif
15751573

15761574
#ifdef CTRL_C_EVENT

0 commit comments

Comments
 (0)