Add preprocesor directives to activate the temporary buffer when needed

Author: pablogsal

Modules/posixmodule.c

@@ -5177,10 +5177,16 @@ enum posix_spawn_file_actions_identifier {
     POSIX_SPAWN_DUP2
 };
 
+#if defined(__GLIBC__) && ((__GLIBC__ == 2 && __GLIBC_MINOR__ < 20))
 static int
 parse_file_actions(PyObject *file_actions,
                    posix_spawn_file_actions_t *file_actionsp,
                    PyObject* temp_buffer)
+#else
+    static int
+    parse_file_actions(PyObject *file_actions,
+                       posix_spawn_file_actions_t *file_actionsp)
+#endif
 {
     PyObject *seq;
     PyObject *file_action = NULL;
@@ -5225,11 +5231,13 @@ parse_file_actions(PyObject *file_actions,
                 {
                     goto fail;
                 }
+#if defined(__GLIBC__) && ((__GLIBC__ == 2 && __GLIBC_MINOR__ < 20))
                 PyList_Append(temp_buffer, path);
+#endif
                 errno = posix_spawn_file_actions_addopen(file_actionsp,
                         fd, PyBytes_AS_STRING(path), oflag, (mode_t)mode);
                 /* addopen copies the value except for some old versions of
-                 * glibc (<2.26). The usage of temp_buffer is a workaround
+                 * glibc (<2.20). The usage of temp_buffer is a workaround
                  * to keep this temporary objects alive until posix_spawn
                  * gets called.*/
                 Py_DECREF(path);
@@ -5361,8 +5369,10 @@ os_posix_spawn_impl(PyObject *module, path_t *path, PyObject *argv,
          * helper functions for manipulating file actions not copy the provided
          * buffers. The use of `temp_buffer` here is a workaround that keeps the
          * python objects that own the buffers alive until posix_spawn gets called.
-         * Check https://bugs.python.org/issue33630 for more info. */
+         * Check https://bugs.python.org/issue33630 and
+         * https://sourceware.org/bugzilla/show_bug.cgi?id=17048 for more info. */
 
+#if defined(__GLIBC__) && ((__GLIBC__ == 2 && __GLIBC_MINOR__ < 20))
         temp_buffer = PyList_New(0);
 
         if (!temp_buffer) {
@@ -5371,6 +5381,11 @@ os_posix_spawn_impl(PyObject *module, path_t *path, PyObject *argv,
         if (parse_file_actions(file_actions, &file_actions_buf, temp_buffer)) {
             goto exit;
         }
+#else
+        if (parse_file_actions(file_actions, &file_actions_buf)) {
+            goto exit;
+        }
+#endif
         file_actionsp = &file_actions_buf;
     }