Skip to content

Commit 9b88d72

Browse files
committed
rename pkgname to mod_name
1 parent 00ffdf2 commit 9b88d72

File tree

1 file changed

+18
-20
lines changed

1 file changed

+18
-20
lines changed

Python/ceval.c

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2763,49 +2763,49 @@ PyObject *
27632763
_PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
27642764
{
27652765
PyObject *x;
2766-
PyObject *fullmodname, *pkgname, *pkgpath, *pkgname_or_unknown, *errmsg;
2766+
PyObject *fullmodname, *mod_name, *pkgpath, *mod_name_or_unknown, *errmsg;
27672767

27682768
if (PyObject_GetOptionalAttr(v, name, &x) != 0) {
27692769
return x;
27702770
}
27712771
/* Issue #17636: in case this failed because of a circular relative
27722772
import, try to fallback on reading the module directly from
27732773
sys.modules. */
2774-
if (PyObject_GetOptionalAttr(v, &_Py_ID(__name__), &pkgname) < 0) {
2774+
if (PyObject_GetOptionalAttr(v, &_Py_ID(__name__), &mod_name) < 0) {
27752775
return NULL;
27762776
}
2777-
if (pkgname == NULL || !PyUnicode_Check(pkgname)) {
2778-
Py_CLEAR(pkgname);
2777+
if (mod_name == NULL || !PyUnicode_Check(mod_name)) {
2778+
Py_CLEAR(mod_name);
27792779
goto error;
27802780
}
2781-
fullmodname = PyUnicode_FromFormat("%U.%U", pkgname, name);
2781+
fullmodname = PyUnicode_FromFormat("%U.%U", mod_name, name);
27822782
if (fullmodname == NULL) {
2783-
Py_DECREF(pkgname);
2783+
Py_DECREF(mod_name);
27842784
return NULL;
27852785
}
27862786
x = PyImport_GetModule(fullmodname);
27872787
Py_DECREF(fullmodname);
27882788
if (x == NULL && !_PyErr_Occurred(tstate)) {
27892789
goto error;
27902790
}
2791-
Py_DECREF(pkgname);
2791+
Py_DECREF(mod_name);
27922792
return x;
27932793
error:
2794-
if (pkgname == NULL) {
2795-
pkgname_or_unknown = PyUnicode_FromString("<unknown module name>");
2796-
if (pkgname_or_unknown == NULL) {
2794+
if (mod_name == NULL) {
2795+
mod_name_or_unknown = PyUnicode_FromString("<unknown module name>");
2796+
if (mod_name_or_unknown == NULL) {
27972797
return NULL;
27982798
}
27992799
} else {
2800-
pkgname_or_unknown = pkgname;
2800+
mod_name_or_unknown = mod_name;
28012801
}
28022802

28032803
pkgpath = NULL;
28042804
if (PyModule_Check(v)) {
28052805
pkgpath = PyModule_GetFilenameObject(v);
28062806
if (pkgpath == NULL) {
28072807
if (!PyErr_ExceptionMatches(PyExc_SystemError)) {
2808-
Py_DECREF(pkgname_or_unknown);
2808+
Py_DECREF(mod_name_or_unknown);
28092809
return NULL;
28102810
}
28112811
// module filename missing
@@ -2816,7 +2816,7 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28162816
Py_CLEAR(pkgpath);
28172817
errmsg = PyUnicode_FromFormat(
28182818
"cannot import name %R from %R (unknown location)",
2819-
name, pkgname_or_unknown
2819+
name, mod_name_or_unknown
28202820
);
28212821
}
28222822
else {
@@ -2827,7 +2827,7 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28272827
Py_DECREF(spec);
28282828
}
28292829
if (rc < 0) {
2830-
Py_DECREF(pkgname_or_unknown);
2830+
Py_DECREF(mod_name_or_unknown);
28312831
Py_DECREF(pkgpath);
28322832
return NULL;
28332833
}
@@ -2837,13 +2837,13 @@ _PyEval_ImportFrom(PyThreadState *tstate, PyObject *v, PyObject *name)
28372837
"(most likely due to a circular import) (%S)" :
28382838
"cannot import name %R from %R (%S)";
28392839

2840-
errmsg = PyUnicode_FromFormat(fmt, name, pkgname_or_unknown, pkgpath);
2840+
errmsg = PyUnicode_FromFormat(fmt, name, mod_name_or_unknown, pkgpath);
28412841
}
2842-
/* NULL checks for errmsg and pkgname done by PyErr_SetImportError. */
2843-
_PyErr_SetImportErrorWithNameFrom(errmsg, pkgname, pkgpath, name);
2842+
/* NULL checks for errmsg and mod_name done by PyErr_SetImportError. */
2843+
_PyErr_SetImportErrorWithNameFrom(errmsg, mod_name, pkgpath, name);
28442844

28452845
Py_XDECREF(errmsg);
2846-
Py_DECREF(pkgname_or_unknown);
2846+
Py_DECREF(mod_name_or_unknown);
28472847
Py_XDECREF(pkgpath);
28482848
return NULL;
28492849
}
@@ -3202,5 +3202,3 @@ _PyEval_LoadName(PyThreadState *tstate, _PyInterpreterFrame *frame, PyObject *na
32023202
}
32033203
return value;
32043204
}
3205-
3206-

0 commit comments

Comments
 (0)