Skip to content

Commit a612176

Browse files
committed
#17493: merge with 3.3.
2 parents c622bf3 + a49178e commit a612176

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

Lib/test/test_sys.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -239,9 +239,6 @@ def f():
239239
def test_recursionlimit_fatalerror(self):
240240
# A fatal error occurs if a second recursion limit is hit when recovering
241241
# from a first one.
242-
if os.name == "nt":
243-
raise unittest.SkipTest(
244-
"under Windows, test would generate a spurious crash dialog")
245242
code = textwrap.dedent("""
246243
import sys
247244
@@ -253,14 +250,15 @@ def f():
253250
254251
sys.setrecursionlimit(%d)
255252
f()""")
256-
for i in (50, 1000):
257-
sub = subprocess.Popen([sys.executable, '-c', code % i],
258-
stderr=subprocess.PIPE)
259-
err = sub.communicate()[1]
260-
self.assertTrue(sub.returncode, sub.returncode)
261-
self.assertTrue(
262-
b"Fatal Python error: Cannot recover from stack overflow" in err,
263-
err)
253+
with test.support.suppress_crash_popup():
254+
for i in (50, 1000):
255+
sub = subprocess.Popen([sys.executable, '-c', code % i],
256+
stderr=subprocess.PIPE)
257+
err = sub.communicate()[1]
258+
self.assertTrue(sub.returncode, sub.returncode)
259+
self.assertIn(
260+
b"Fatal Python error: Cannot recover from stack overflow",
261+
err)
264262

265263
def test_getwindowsversion(self):
266264
# Raise SkipTest if sys doesn't have getwindowsversion attribute

0 commit comments

Comments
 (0)