NotImplementedError -> RuntimeError

Author: 1st1

Lib/asyncio/tasks.py

@@ -115,10 +115,10 @@ def _repr_info(self):
         return base_tasks._task_repr_info(self)
 
     def set_result(self, result):
-        raise NotImplementedError
+        raise RuntimeError('Tasks do not support set_result operation')
 
     def set_exception(self, exception):
-        raise NotImplementedError
+        raise RuntimeError('Tasks do not support set_exception operation')
 
     def get_stack(self, *, limit=None):
         """Return the list of stack frames for this task's coroutine.

Lib/test/test_asyncio/test_tasks.py

@@ -1340,10 +1340,10 @@ def notmuch():
         gen = notmuch()
         task = self.new_task(self.loop, gen)
 
-        with self.assertRaises(NotImplementedError):
+        with self.assertRaisesRegex(RuntimeError, 'not support set_result'):
             task.set_result('ok')
 
-        with self.assertRaises(NotImplementedError):
+        with self.assertRaisesRegex(RuntimeError, 'not support set_exception'):
             task.set_exception(ValueError())
 
         self.assertEqual(

Modules/_asynciomodule.c

@@ -2243,7 +2243,8 @@ static PyObject *
 _asyncio_Task_set_result(TaskObj *self, PyObject *result)
 /*[clinic end generated code: output=1dcae308bfcba318 input=9d1a00c07be41bab]*/
 {
-    PyErr_SetNone(PyExc_NotImplementedError);
+    PyErr_SetString(PyExc_RuntimeError,
+                    "Tasks do not support set_result operation");
     return NULL;
 }
 
@@ -2258,7 +2259,8 @@ static PyObject *
 _asyncio_Task_set_exception(TaskObj *self, PyObject *exception)
 /*[clinic end generated code: output=bc377fc28067303d input=9a8f65c83dcf893a]*/
 {
-    PyErr_SetNone(PyExc_NotImplementedError);
+    PyErr_SetString(PyExc_RuntimeError,
+                    "Tasks do not support set_exception operation");
     return NULL;
 }