Skip to content

Commit af1d4e6

Browse files
fix comment
1 parent 6b9d8c1 commit af1d4e6

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Lib/asyncio/base_subprocess.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ def _process_exited(self, returncode):
219219
# The pipes should not be closed otherwise some data may be lost.
220220
# If the pipe is closed here then _UnixReadPipeTransport will remove the
221221
# reader prematurely and the data will be lost, instead of doing that
222-
# the pipe will be closed when the process is finished.
222+
# the pipe will be closed when the process is finished via _pipe_connection_lost
223+
# followed by _try_finish.
223224
# for p in self._pipes.values():
224225
# if p is not None:
225226
# p.pipe.close()

Lib/test/test_asyncio/test_subprocess.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ async def execute():
686686

687687
self.assertIsNone(self.loop.run_until_complete(execute()))
688688

689-
def test_subprocess_output_stdout(self):
689+
def test_subprocess_communicate_stdout(self):
690690
# See https://github.com/python/cpython/issues/100133
691691
async def get_command_stdout(cmd, *args):
692692
proc = await asyncio.create_subprocess_exec(

0 commit comments

Comments
 (0)