[3.13] gh-131762: Fixed dereferencing the pointer 'parser_token->metadata' with a NULL value (GH-131764) (#131774)

miss-islington · rialbat · web-flow · commit b0f387605457 · 2025-03-26T19:07:51.000Z
gh-131762: Fixed dereferencing the pointer 'parser_token->metadata' with a NULL value (GH-131764) (cherry picked from commit 2c686a9) Co-authored-by: rialbat <47256826+rialbat@users.noreply.github.com>
diff --git a/Parser/pegen.c b/Parser/pegen.c
@@ -191,7 +191,7 @@ initialize_token(Parser *p, Token *parser_token, struct token *new_token, int to
     parser_token->metadata = NULL;
     if (new_token->metadata != NULL) {
         if (_PyArena_AddPyObject(p->arena, new_token->metadata) < 0) {
-            Py_DECREF(parser_token->metadata);
+            Py_DECREF(new_token->metadata);
             return -1;
         }
         parser_token->metadata = new_token->metadata;

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ initialize_token(Parser p, Token parser_token, struct token *new_token, int to`
`191`	`191`	`parser_token->metadata = NULL;`
`192`	`192`	`if (new_token->metadata != NULL) {`
`193`	`193`	`if (_PyArena_AddPyObject(p->arena, new_token->metadata) < 0) {`
`194`		`- Py_DECREF(parser_token->metadata);`
	`194`	`+ Py_DECREF(new_token->metadata);`
`195`	`195`	`return -1;`
`196`	`196`	`}`
`197`	`197`	`parser_token->metadata = new_token->metadata;`