Skip to content

Commit b8c7be2

Browse files
authored
bpo-31234: Join threads in test_threading (#3579)
Call thread.join() to prevent the "dangling thread" warning.
1 parent c8d8e15 commit b8c7be2

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Lib/test/test_threading.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,7 @@ def f():
578578
self.assertFalse(t.is_alive())
579579
# And verify the thread disposed of _tstate_lock.
580580
self.assertIsNone(t._tstate_lock)
581+
t.join()
581582

582583
def test_repr_stopped(self):
583584
# Verify that "stopped" shows up in repr(Thread) appropriately.
@@ -604,6 +605,7 @@ def f():
604605
break
605606
time.sleep(0.01)
606607
self.assertIn(LOOKING_FOR, repr(t)) # we waited at least 5 seconds
608+
t.join()
607609

608610
def test_BoundedSemaphore_limit(self):
609611
# BoundedSemaphore should raise ValueError if released too often.
@@ -918,6 +920,7 @@ def test_start_thread_again(self):
918920
thread = threading.Thread()
919921
thread.start()
920922
self.assertRaises(RuntimeError, thread.start)
923+
thread.join()
921924

922925
def test_joining_current_thread(self):
923926
current_thread = threading.current_thread()
@@ -931,6 +934,7 @@ def test_daemonize_active_thread(self):
931934
thread = threading.Thread()
932935
thread.start()
933936
self.assertRaises(RuntimeError, setattr, thread, "daemon", True)
937+
thread.join()
934938

935939
def test_releasing_unacquired_lock(self):
936940
lock = threading.Lock()

0 commit comments

Comments
 (0)