gh-121660: Fix ga_getitem by explicitly checking for NULL result (#121661)

sobolevn · web-flow · commit bb802db8cfa3 · 2024-07-14T14:20:40.000+03:00
diff --git a/Objects/genericaliasobject.c b/Objects/genericaliasobject.c
@@ -563,6 +563,10 @@ ga_getitem(PyObject *self, PyObject *item)
     }
 
     PyObject *res = Py_GenericAlias(alias->origin, newargs);
+    if (res == NULL) {
+        Py_DECREF(newargs);
+        return NULL;
+    }
     ((gaobject *)res)->starred = alias->starred;
 
     Py_DECREF(newargs);

Original file line number	Diff line number	Diff line change
`@@ -563,6 +563,10 @@ ga_getitem(PyObject self, PyObject item)`
`563`	`563`	`}`
`564`	`564`
`565`	`565`	`PyObject *res = Py_GenericAlias(alias->origin, newargs);`
	`566`	`+ if (res == NULL) {`
	`567`	`+ Py_DECREF(newargs);`
	`568`	`+ return NULL;`
	`569`	`+ }`
`566`	`570`	`((gaobject *)res)->starred = alias->starred;`
`567`	`571`
`568`	`572`	`Py_DECREF(newargs);`