Apply suggestions

Author: isidentical

Lib/traceback.py

@@ -592,7 +592,9 @@ def _extract_caret_anchors_from_line_segment(segment):
         case ast.Expr(expr):
             match expr:
                 case ast.BinOp():
-                    operator_str = segment[normalize(expr.left.end_col_offset):normalize(expr.right.col_offset)]
+                    operator_start = normalize(expr.left.end_col_offset)
+                    operator_end = normalize(expr.right.col_offset)
+                    operator_str = segment[operator_start:operator_end]
                     operator_offset = len(operator_str) - len(operator_str.lstrip())
 
                     left_anchor = expr.left.end_col_offset + operator_offset
@@ -604,7 +606,9 @@ def _extract_caret_anchors_from_line_segment(segment):
                         right_anchor += 1
                     return _Anchors(normalize(left_anchor), normalize(right_anchor))
                 case ast.Subscript():
-                    return _Anchors(normalize(expr.value.end_col_offset), normalize(expr.slice.end_col_offset + 1))
+                    subscript_start = normalize(expr.value.end_col_offset)
+                    subscript_end = normalize(expr.slice.end_col_offset + 1)
+                    return _Anchors(subscript_start, subscript_end)
 
     return None
 

Misc/NEWS.d/next/Core and Builtins/2022-11-06-00-17-58.gh-issue-99103.bFA9BX.rst

@@ -1,2 +1,2 @@
 Fix the error reporting positions of specialized traceback anchors when the
-source line contains unicode characters.
+source line contains Unicode characters.

Python/traceback.c

@@ -705,9 +705,11 @@ extract_anchors_from_line(PyObject *filename, PyObject *line,
 
 done:
     if (res > 0) {
-        // Normalize the AST offsets to byte offsets and adjust it with the
+        // Normalize the AST offsets to byte offsets and adjust them with the
         // start of the actual line (instead of the source code segment).
         assert(segment != NULL);
+        assert(*left_anchor >= 0);
+        assert(*right_anchor >= 0);
         *left_anchor = _PyPegen_byte_offset_to_character_offset(segment, *left_anchor) + start_offset;
         *right_anchor = _PyPegen_byte_offset_to_character_offset(segment, *right_anchor) + start_offset;
     }