Skip to content

Commit cb43754

Browse files
committed
Add inline comments Ezio wanted
1 parent f2af908 commit cb43754

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/require-pr-label.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
timeout-minutes: 10
3131

3232
steps:
33+
# Check that the PR is not awaiting changes from the author due to previous review.
3334
- name: Check there's no required changes
3435
uses: mheap/github-action-required-labels@v5
3536
with:
@@ -39,14 +40,15 @@ jobs:
3940
awaiting changes
4041
awaiting change review
4142
- id: is-feature
42-
name: Check for type-feature
43+
name: Check whether this PR is a feature (contains a "type-feature" label)
4344
uses: mheap/github-action-required-labels@v5
4445
with:
4546
mode: exactly
4647
count: 1
4748
labels: |
4849
type-feature
49-
exit_type: success
50+
exit_type: success # don't fail the check if the PR is not a feature, just record the result
51+
# In case of a feature PR, check for a complete review (contains an "awaiting merge" label).
5052
- id: awaiting-merge
5153
if: steps.is-feature.outputs.status == 'success'
5254
name: Check for complete review

0 commit comments

Comments
 (0)