bpo-46383: Fix signature of zoneinfo module_free function (GH-30607)

tiran · web-flow · commit cfbde65df318 · 2022-01-15T09:52:19.000+01:00
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-01-14-20-55-34.bpo-46383.v8MTl4.rst b/Misc/NEWS.d/next/Core and Builtins/2022-01-14-20-55-34.bpo-46383.v8MTl4.rst
@@ -0,0 +1,2 @@
+Fix invalid signature of ``_zoneinfo``'s ``module_free`` function to resolve
+a crash on wasm32-emscripten platform.
diff --git a/Modules/_zoneinfo.c b/Modules/_zoneinfo.c
@@ -2612,7 +2612,7 @@ static PyTypeObject PyZoneInfo_ZoneInfoType = {
 // Specify the _zoneinfo module
 static PyMethodDef module_methods[] = {{NULL, NULL}};
 static void
-module_free(void)
+module_free(void *m)
 {
     Py_XDECREF(_tzpath_find_tzfile);
     _tzpath_find_tzfile = NULL;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fix invalid signature of ``_zoneinfo``'s ``module_free`` function to resolve
	`2`	`+a crash on wasm32-emscripten platform.`
Original file line number	Diff line number	Diff line change
`@@ -2612,7 +2612,7 @@ static PyTypeObject PyZoneInfo_ZoneInfoType = {`
`2612`	`2612`	`// Specify the _zoneinfo module`
`2613`	`2613`	`static PyMethodDef module_methods[] = {{NULL, NULL}};`
`2614`	`2614`	`static void`
`2615`		`-module_free(void)`
	`2615`	`+module_free(void *m)`
`2616`	`2616`	`{`
`2617`	`2617`	`Py_XDECREF(_tzpath_find_tzfile);`
`2618`	`2618`	`_tzpath_find_tzfile = NULL;`