Skip to content

Commit d281005

Browse files
authored
tempfile: Use random.choises() instead of choise() (GH-23068)
1 parent 2165cea commit d281005

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

Lib/tempfile.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,7 @@ def __iter__(self):
143143
return self
144144

145145
def __next__(self):
146-
c = self.characters
147-
choose = self.rng.choice
148-
letters = [choose(c) for dummy in range(8)]
149-
return ''.join(letters)
146+
return ''.join(self.rng.choices(self.characters, k=8))
150147

151148
def _candidate_tempdir_list():
152149
"""Generate a list of candidate temporary directories which

Lib/test/test_tempfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ def setUp(self):
153153
self.r = tempfile._RandomNameSequence()
154154
super().setUp()
155155

156-
def test_get_six_char_str(self):
157-
# _RandomNameSequence returns a six-character string
156+
def test_get_eight_char_str(self):
157+
# _RandomNameSequence returns a eight-character string
158158
s = next(self.r)
159159
self.nameCheck(s, '', '', '')
160160

0 commit comments

Comments
 (0)