Address code review

corona10 · corona10 · commit d6955d7fc12b · 2022-11-05T23:01:29.000+09:00
diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c
@@ -409,8 +409,11 @@ static int
 _syslog_clear(PyObject *module)
 {
     _syslog_state *state = get_syslog_state(module);
-    Py_CLEAR(state->S_ident_o);
-    state->S_log_open = 0;
+    if (state->S_log_open) {
+        closelog();
+        Py_CLEAR(state->S_ident_o);
+        state->S_log_open = 0;
+    }
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -409,8 +409,11 @@ static int`
`409`	`409`	`_syslog_clear(PyObject *module)`
`410`	`410`	`{`
`411`	`411`	`_syslog_state *state = get_syslog_state(module);`
`412`		`- Py_CLEAR(state->S_ident_o);`
`413`		`- state->S_log_open = 0;`
	`412`	`+ if (state->S_log_open) {`
	`413`	`+ closelog();`
	`414`	`+ Py_CLEAR(state->S_ident_o);`
	`415`	`+ state->S_log_open = 0;`
	`416`	`+ }`
`414`	`417`	`return 0;`
`415`	`418`	`}`
`416`	`419`