Skip to content

Commit d89cea1

Browse files
Penlectvsajip
authored andcommitted
bpo-38781: Clear buffer in MemoryHandler flush (GH-17132)
This makes it easier to use a custom buffer when subclassing MemoryHandler (by avoiding the explicity empty list literal assignment in the flush method). For example, collection.deque can now be used without any modifications to MemoryHandler.flush. The same applies to BufferingHandler.
1 parent 9c28449 commit d89cea1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Lib/logging/handlers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,7 @@ def flush(self):
12541254
"""
12551255
self.acquire()
12561256
try:
1257-
self.buffer = []
1257+
self.buffer.clear()
12581258
finally:
12591259
self.release()
12601260

@@ -1321,7 +1321,7 @@ def flush(self):
13211321
if self.target:
13221322
for record in self.buffer:
13231323
self.target.handle(record)
1324-
self.buffer = []
1324+
self.buffer.clear()
13251325
finally:
13261326
self.release()
13271327

0 commit comments

Comments
 (0)