Skip to content

Commit e0c88f0

Browse files
committed
Exception -> BaseException
1 parent e4e968a commit e0c88f0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Lib/test/test_typing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7534,7 +7534,7 @@ class Foo(NamedTuple):
75347534
self.assertEqual(foo.attr.name, "attr")
75357535

75367536
def test_setname_raises_the_same_as_on_other_classes(self):
7537-
class CustomException(Exception): pass
7537+
class CustomException(BaseException): pass
75387538

75397539
class Annoying:
75407540
def __set_name__(self, owner, name):

Lib/typing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2734,7 +2734,7 @@ def __new__(cls, typename, bases, ns):
27342734
if hasattr(type(val), "__set_name__"):
27352735
try:
27362736
type(val).__set_name__(val, nm_tpl, key)
2737-
except Exception as e:
2737+
except BaseException as e:
27382738
e.add_note(
27392739
f"Error calling __set_name__ on {type(val).__name__!r} "
27402740
f"instance {key!r} in {typename!r}"

0 commit comments

Comments
 (0)