File tree Expand file tree Collapse file tree 2 files changed +13
-3
lines changed Expand file tree Collapse file tree 2 files changed +13
-3
lines changed Original file line number Diff line number Diff line change
1
+ Improved error message when building without a Windows SDK installed.
Original file line number Diff line number Diff line change 109
109
110
110
<!-- The minimum allowed SDK version to use for building -->
111
111
<DefaultWindowsSDKVersion >10.0.10586.0</DefaultWindowsSDKVersion >
112
- <DefaultWindowsSDKVersion Condition =" $([System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))" >$(_RegistryVersion)</DefaultWindowsSDKVersion >
112
+ <DefaultWindowsSDKVersion Condition =" $(_RegistryVersion) != '' and $( [System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))" >$(_RegistryVersion)</DefaultWindowsSDKVersion >
113
113
</PropertyGroup >
114
-
114
+
115
+ <Target Name =" _CheckWindowsSDKFound" BeforeTargets =" _CheckWindowsSDKInstalled" Condition =" $(_RegistryVersion) == ''" >
116
+ <PropertyGroup >
117
+ <_Message >Failed to locate a Windows SDK installation.</_Message >
118
+ <_Message >$(_Message) If the build fails, please use the Visual Studio Installer to install the Windows SDK.</_Message >
119
+ <_Message >$(_Message) (Ignore the version number specified in the error message and select the latest.)</_Message >
120
+ </PropertyGroup >
121
+ <Warning Text =" $(_Message)" />
122
+ </Target >
123
+
115
124
<PropertyGroup Condition =" $(WindowsTargetPlatformVersion) == ''" >
116
125
<WindowsTargetPlatformVersion >$(DefaultWindowsSDKVersion)</WindowsTargetPlatformVersion >
117
126
</PropertyGroup >
176
185
<ReleaseLevelNumber Condition =" $(_ReleaseLevel) == 'b'" >11</ReleaseLevelNumber >
177
186
<ReleaseLevelNumber Condition =" $(_ReleaseLevel) == 'rc'" >12</ReleaseLevelNumber >
178
187
</PropertyGroup >
179
-
188
+
180
189
<PropertyGroup >
181
190
<PythonVersionNumber >$(MajorVersionNumber).$(MinorVersionNumber).$(MicroVersionNumber)</PythonVersionNumber >
182
191
<PythonVersion >$(MajorVersionNumber).$(MinorVersionNumber).$(MicroVersionNumber)$(ReleaseLevelName)</PythonVersion >
You can’t perform that action at this time.
0 commit comments