fix lock leak introduced by initial change

carsonRadtke · carsonRadtke · commit ec1d48db055e · 2024-06-16T10:09:24.000-05:00
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -2515,12 +2515,12 @@ PyAPI_FUNC(int) PyUnstable_CopyPerfMapFile(const char* parent_filename) {
             return ret;
         }
     }
-    char buf[4096];
-    PyThread_acquire_lock(perf_map_state.map_lock, 1);
     FILE* from = fopen(parent_filename, "r");
     if (!from) {
         return -1;
     }
+    char buf[4096];
+    PyThread_acquire_lock(perf_map_state.map_lock, 1);
     int fflush_result = 0, result = 0;
     while (1) {
         size_t bytes_read = fread(buf, 1, sizeof(buf), from);

Original file line number	Diff line number	Diff line change
`@@ -2515,12 +2515,12 @@ PyAPI_FUNC(int) PyUnstable_CopyPerfMapFile(const char* parent_filename) {`
`2515`	`2515`	`return ret;`
`2516`	`2516`	`}`
`2517`	`2517`	`}`
`2518`		`- char buf[4096];`
`2519`		`- PyThread_acquire_lock(perf_map_state.map_lock, 1);`
`2520`	`2518`	`FILE* from = fopen(parent_filename, "r");`
`2521`	`2519`	`if (!from) {`
`2522`	`2520`	`return -1;`
`2523`	`2521`	`}`
	`2522`	`+ char buf[4096];`
	`2523`	`+ PyThread_acquire_lock(perf_map_state.map_lock, 1);`
`2524`	`2524`	`int fflush_result = 0, result = 0;`
`2525`	`2525`	`while (1) {`
`2526`	`2526`	`size_t bytes_read = fread(buf, 1, sizeof(buf), from);`