Skip to content

Commit fad4210

Browse files
committed
bpo-46323 Address code review
1 parent 4b18483 commit fad4210

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

Modules/_ctypes/callbacks.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -180,14 +180,12 @@ static void _CallPythonObject(void *mem,
180180
PyObject *cnv = cnvs[i];
181181
StgDictObject *dict;
182182

183-
Py_INCREF(cnv);
184183
dict = PyType_stgdict(cnv);
185184

186185
if (dict && dict->getfunc && !_ctypes_simple_instance(cnv)) {
187186
PyObject *v = dict->getfunc(*pArgs, dict->size);
188187
if (!v) {
189188
PrintError("create argument %zd:\n", i);
190-
Py_DECREF(cnv);
191189
goto Done;
192190
}
193191
args[i] = v;
@@ -206,7 +204,6 @@ static void _CallPythonObject(void *mem,
206204
}
207205
if (!CDataObject_Check(obj)) {
208206
Py_DECREF(obj);
209-
Py_DECREF(cnv);
210207
PrintError("unexpected result of create argument %zd:\n", i);
211208
goto Done;
212209
}
@@ -219,10 +216,8 @@ static void _CallPythonObject(void *mem,
219216
PyErr_SetString(PyExc_TypeError,
220217
"cannot build parameter");
221218
PrintError("Parsing argument %zd\n", i);
222-
Py_DECREF(cnv);
223219
goto Done;
224220
}
225-
Py_DECREF(cnv);
226221
/* XXX error handling! */
227222
pArgs++;
228223
}
@@ -391,11 +386,7 @@ CThunkObject *_ctypes_alloc_callback(PyObject *callable,
391386
PyObject **cnvs = PySequence_Fast_ITEMS(converters);
392387
for (i = 0; i < nArgs; ++i) {
393388
PyObject *cnv = cnvs[i];
394-
if (cnv == NULL)
395-
goto error;
396-
Py_INCREF(cnv);
397389
p->atypes[i] = _ctypes_get_ffi_type(cnv);
398-
Py_DECREF(cnv);
399390
}
400391
p->atypes[i] = NULL;
401392

0 commit comments

Comments
 (0)