bpo-25430: improve performance of IPNetwork.__contains__ #1785
Conversation
make a compare in bit-operation manner
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@gescheit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @serhiy-storchaka and @hynek to be potential reviewers. |
|
Changed the CLA label as @gescheit is recorded as having signed it in Roundup: https://bugs.python.org/user15300 |
pitrou
changed the title
|
Thanks @gescheit, changes looks good to me! |
|
What is performance boost? |
|
@asvetlov you can find numbers in the description of the BPO. |
|
Got you. Thanks. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Ping @gescheit . This seems to be blocking only on NEWS entry. Can you please add one? It would be nice to see this as part of next release. You can add it from the web interface using https://blurb-it.herokuapp.com/ or using the blurb tool at https://pypi.org/project/blurb/ Thanks |
make a compare in bit-operation manner
see http://bugs.python.org/issue25430 for detail
https://bugs.python.org/issue25430