Skip to content

bpo-31873: Change 12 instances of 'unicode' to 'Unicode' #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2019

Conversation

toonarmycaptain
Copy link
Contributor

@toonarmycaptain toonarmycaptain commented Oct 26, 2017

Update 'unicode' capitalization. 'Unicode' is a proper noun, and as such should be capitalized, currently the capitalization is inconsistent throughout the document.
Changed 12 instances.

https://bugs.python.org/issue31873

Update 'unicode' capitalization. 'Unicode' is a proper noun, and as such should be capitalized. 
Changed multiple instances.
@toonarmycaptain toonarmycaptain changed the title Change 12 instances of 'unicode' to 'Unicode' Change 12 instances of 'unicode' to 'Unicode' label:"skip issue" Oct 26, 2017
@toonarmycaptain toonarmycaptain changed the title Change 12 instances of 'unicode' to 'Unicode' label:"skip issue" Change 12 instances of 'unicode' to 'Unicode' Oct 26, 2017
@serhiy-storchaka
Copy link
Member

This doesn't look doubtless to me. Please open an issue on the tracker for discussion.

@toonarmycaptain
Copy link
Contributor Author

@serhiy-storchaka I fixed a dozen cases to make the capitalization uniform throughout the document, but can do.

@toonarmycaptain
Copy link
Contributor Author

Opened Issue 31873.

@serhiy-storchaka serhiy-storchaka changed the title Change 12 instances of 'unicode' to 'Unicode' bpo-31873: Change 12 instances of 'unicode' to 'Unicode' Mar 26, 2018
Copy link
Member

@JulienPalard JulienPalard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 1233 Unicode for 265 unicode in the doc. 89 Unicode obj for only 8 unicode obj, so for consistency I'm OK with this.
Also from a spellchecking point of view, I prefer Unicode over unicode (yes we use one in the french translation and we capitalized all Unicode occurrences to avoid spellcheck errors).

@miss-islington
Copy link
Contributor

Thanks @toonarmycaptain for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2019
Update 'unicode' capitalization. 'Unicode' is a proper noun, and as such should be capitalized.
Changed multiple instances.
(cherry picked from commit 85225b6)

Co-authored-by: toonarmycaptain <[email protected]>
@bedevere-bot
Copy link

GH-13194 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 8, 2019
Update 'unicode' capitalization. 'Unicode' is a proper noun, and as such should be capitalized.
Changed multiple instances.
(cherry picked from commit 85225b6)

Co-authored-by: toonarmycaptain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants