Skip to content

Commit b466e78

Browse files
committed
Avoid copy-paste of function call with a lots of arguments.
1 parent 3d057f0 commit b466e78

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

build_docs.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -219,18 +219,16 @@ def main():
219219
sphinxbuild = os.path.join(args.build_root, "environment/bin/sphinx-build")
220220
try:
221221
if args.branch:
222-
build_one(args.branch, args.devel, args.quick, sphinxbuild,
223-
args.build_root, args.www_root,
224-
args.skip_cache_invalidation,
225-
args.group, args.git, args.log_directory)
222+
branches_to_do = [(args.branch, args.devel)]
226223
else:
227-
for version, devel in BRANCHES:
228-
build_one(version, devel, args.quick, sphinxbuild,
229-
args.build_root, args.www_root,
230-
args.skip_cache_invalidation, args.group, args.git,
231-
args.log_directory)
232-
build_devguide(args.devguide_checkout, args.devguide_target,
233-
sphinxbuild, args.skip_cache_invalidation)
224+
branches_to_do = BRANCHES
225+
for version, devel in branches_to_do:
226+
build_one(version, devel, args.quick, sphinxbuild,
227+
args.build_root, args.www_root,
228+
args.skip_cache_invalidation, args.group, args.git,
229+
args.log_directory)
230+
build_devguide(args.devguide_checkout, args.devguide_target,
231+
sphinxbuild, args.skip_cache_invalidation)
234232
except Exception:
235233
logging.exception("docs build raised exception")
236234

0 commit comments

Comments
 (0)