Rephrase flag to more closely match similar flags

"Disallow" didn't feel right here since mypy was still obeying the
ignore comment. "Warn" is more precise since this is configuring
a new warning to be emitted.

This also adjusts the pluralisation in a way I think is better.

Author: PeterJCLaw

docs/source/command_line.rst

@@ -440,10 +440,10 @@ potentially problematic or redundant in some way.
     These two flags let you discover cases where either workarounds are
     no longer necessary.
 
-.. option:: --disallow-ignore-without-code
+.. option:: --warn-ignores-without-codes
 
-    This flag will disallow ``# type: ignore`` comments which do not have
-    error codes::
+    This flag will make mypy report an error for any ``# type: ignore`` comments
+    which do not have error codes::
 
         prog.py:1: error: "type: ignore" comment without error code
 

docs/source/config_file.rst

@@ -507,12 +507,12 @@ section of the command line docs.
 
     Warns about unneeded ``# type: ignore`` comments.
 
-.. confval:: disallow_ignore_without_code
+.. confval:: warn_ignores_without_codes
 
     :type: boolean
     :default: False
 
-    Disallow ``# type: ignore`` comments which do not have error codes.
+    Warn about '# type: ignore' comments which do not have error codes.
 
 .. confval:: warn_no_return
 

mypy/build.py

@@ -2370,7 +2370,7 @@ def generate_unused_ignore_notes(self) -> None:
             self.manager.errors.generate_unused_ignore_errors(self.xpath)
 
     def generate_ignore_without_code_notes(self) -> None:
-        if self.options.disallow_ignore_without_code:
+        if self.options.warn_ignores_without_codes:
             self.manager.errors.generate_ignore_without_code_errors(
                 self.xpath,
                 self.options.warn_unused_ignores,

mypy/main.py

@@ -637,7 +637,7 @@ def add_invertible_flag(flag: str,
     add_invertible_flag('--warn-unused-ignores', default=False, strict_flag=True,
                         help="Warn about unneeded '# type: ignore' comments",
                         group=lint_group)
-    add_invertible_flag('--disallow-ignore-without-code', default=False,
+    add_invertible_flag('--warn-ignores-without-codes', default=False,
                         help="Disallow '# type: ignore' comments which do not have error codes",
                         group=lint_group)
     add_invertible_flag('--no-warn-no-return', dest='warn_no_return', default=True,

mypy/options.py

@@ -32,7 +32,6 @@ class BuildType:
     "disallow_any_expr",
     "disallow_any_generics",
     "disallow_any_unimported",
-    "disallow_ignore_without_code",
     "disallow_incomplete_defs",
     "disallow_subclassing_any",
     "disallow_untyped_calls",
@@ -50,6 +49,7 @@ class BuildType:
     "strict_equality",
     "strict_optional",
     "strict_optional_whitelist",
+    "warn_ignores_without_codes",
     "warn_no_return",
     "warn_return_any",
     "warn_unreachable",
@@ -144,8 +144,8 @@ def __init__(self) -> None:
         # Warn about unused '# type: ignore' comments
         self.warn_unused_ignores = False
 
-        # Warn about '# type: ignore' comments without error codes
-        self.disallow_ignore_without_code = False
+        # Warn about '# type: ignore' comments which do not have error codes
+        self.warn_ignores_without_codes = False
 
         # Warn about unused '[mypy-<pattern>]'  or '[[tool.mypy.overrides]]' config sections
         self.warn_unused_configs = False

test-data/unit/check-errorcodes.test

@@ -136,16 +136,16 @@ x # type: ignore[name-defined, attr-defined] # E: Unused "type: ignore[attr-defi
 "x" # type: ignore[name-defined] # E: Unused "type: ignore" comment
 
 [case testErrorCodeMissingWhenRequired]
-# flags: --disallow-ignore-without-code
+# flags: --warn-ignores-without-codes
 "x" # type: ignore # E: "type: ignore" comment without error code
 y # type: ignore # E: "type: ignore" comment without error code (hint: add [name-defined])
 
 [case testErrorCodeMissingDoesntTrampleUnusedIgnoresWarning]
-# flags: --disallow-ignore-without-code --warn-unused-ignores
+# flags: --warn-ignores-without-codes --warn-unused-ignores
 "x" # type: ignore # E: Unused "type: ignore" comment
 
 [case testErrorCodeMissingWholeFileIgnores]
-# flags: --disallow-ignore-without-code
+# flags: --warn-ignores-without-codes
 # type: ignore  # whole file ignore
 x
 y # type: ignore  # ignore the lack of error code since we're ignore the whole file