Further speed up union simplification (#12541)

This tweaks a change made in #12539 that may have slowed things
down. The behavior introduced in the PR was more correct, but it's not
worth a potential major performance regression, since union
simplification is not something we have to get always right for
correctness.

Work on #12526.

Author: JukkaL

mypy/test/testtypes.py

@@ -12,7 +12,7 @@
 from mypy.types import (
     UnboundType, AnyType, CallableType, TupleType, TypeVarType, Type, Instance, NoneType,
     Overloaded, TypeType, UnionType, UninhabitedType, TypeVarId, TypeOfAny, ProperType,
-    get_proper_type
+    LiteralType, get_proper_type
 )
 from mypy.nodes import ARG_POS, ARG_OPT, ARG_STAR, ARG_STAR2, CONTRAVARIANT, INVARIANT, COVARIANT
 from mypy.subtypes import is_subtype, is_more_precise, is_proper_subtype
@@ -496,6 +496,14 @@ def test_simplified_union_with_str_literals(self) -> None:
         self.assert_simplified_union([fx.lit_str1, fx.lit_str2, fx.uninhabited],
                                      UnionType([fx.lit_str1, fx.lit_str2]))
 
+    def test_simplify_very_large_union(self) -> None:
+        fx = self.fx
+        literals = []
+        for i in range(5000):
+            literals.append(LiteralType("v%d" % i, fx.str_type))
+        # This shouldn't be very slow, even if the union is big.
+        self.assert_simplified_union([*literals, fx.str_type], fx.str_type)
+
     def test_simplified_union_with_str_instance_literals(self) -> None:
         fx = self.fx
 

mypy/typeops.py

@@ -318,6 +318,15 @@ def simple_literal_value_key(t: ProperType) -> Optional[Tuple[str, ...]]:
     return None
 
 
+def is_simple_literal(t: ProperType) -> bool:
+    """Fast way to check if simple_literal_value_key() would return a non-None value."""
+    if isinstance(t, LiteralType):
+        return t.fallback.type.is_enum or t.fallback.type.fullname == 'builtins.str'
+    if isinstance(t, Instance):
+        return t.last_known_value is not None and isinstance(t.last_known_value.value, str)
+    return False
+
+
 def make_simplified_union(items: Sequence[Type],
                           line: int = -1, column: int = -1,
                           *, keep_erased: bool = False,
@@ -392,17 +401,26 @@ def _remove_redundant_union_items(items: List[ProperType], keep_erased: bool) ->
 
         # Keep track of the truishness info for deleted subtypes which can be relevant
         cbt = cbf = False
+        num_items = len(items)
         for j, tj in enumerate(items):
-            # NB: we don't need to check literals as the fast path above takes care of that
-            if (
-                    i != j
+            if i != j:
+                # NB: The first check below is an optimization to
+                #     avoid very expensive computations with large
+                #     unions involving literals. We approximate the
+                #     results for unions with many items. This is
+                #     "fine" since simplifying these union items is
+                #     (almost) always optional.
+                if (
+                    (num_items < 5
+                     or is_likely_literal_supertype(item)
+                     or not is_simple_literal(tj))
                     and is_proper_subtype(tj, item, keep_erased_types=keep_erased)
                     and is_redundant_literal_instance(item, tj)  # XXX?
-            ):
-                # We found a redundant item in the union.
-                removed.add(j)
-                cbt = cbt or tj.can_be_true
-                cbf = cbf or tj.can_be_false
+                ):
+                    # We found a redundant item in the union.
+                    removed.add(j)
+                    cbt = cbt or tj.can_be_true
+                    cbf = cbf or tj.can_be_false
         # if deleted subtypes had more general truthiness, use that
         if not item.can_be_true and cbt:
             items[i] = true_or_false(item)
@@ -412,6 +430,12 @@ def _remove_redundant_union_items(items: List[ProperType], keep_erased: bool) ->
     return [items[i] for i in range(len(items)) if i not in removed]
 
 
+def is_likely_literal_supertype(t: ProperType) -> bool:
+    """Is the type likely to cause simplification of literal types in unions?"""
+    return isinstance(t, Instance) and t.type.fullname in ('builtins.object',
+                                                           'builtins.str')
+
+
 def _get_type_special_method_bool_ret_type(t: Type) -> Optional[Type]:
     t = get_proper_type(t)