Skip to content

Commit b3eff87

Browse files
authored
Clarify status in dmypy status output (#18331)
Revised the status message output from the `dmypy status` command to eliminate potential misunderstandings about the daemon's operational state. Given the daemon’s synchronous design, the server may appear unresponsive during periods of heavy processing. When encountering a timeout, the status message could suggest that the daemon was "stuck", prompting users to prematurely consider stopping it. Fixes #18008
1 parent 2d6b521 commit b3eff87

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mypy/dmypy/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ def do_status(args: argparse.Namespace) -> None:
436436
if args.verbose or "error" in response:
437437
show_stats(response)
438438
if "error" in response:
439-
fail(f"Daemon is stuck; consider {sys.argv[0]} kill")
439+
fail(f"Daemon may be busy processing; if this persists, consider {sys.argv[0]} kill")
440440
print("Daemon is up and running")
441441

442442

@@ -447,7 +447,7 @@ def do_stop(args: argparse.Namespace) -> None:
447447
response = request(args.status_file, "stop", timeout=5)
448448
if "error" in response:
449449
show_stats(response)
450-
fail(f"Daemon is stuck; consider {sys.argv[0]} kill")
450+
fail(f"Daemon may be busy processing; if this persists, consider {sys.argv[0]} kill")
451451
else:
452452
print("Daemon stopped")
453453

0 commit comments

Comments
 (0)